Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ......................................................................
Patch Set 10: Code-Review+1 (3 comments) Sorry for the delay. I've made the changes. Carry +1 http://gerrit.cloudera.org:8080/#/c/4371/9/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: PS9, Line 256: // Protects min > comment on what this protects Done http://gerrit.cloudera.org:8080/#/c/4371/9/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS9, Line 1019: lock_guard<SpinLock> > Was there a reason not to take lock_ here? No, that was a mistake. Added it now. http://gerrit.cloudera.org:8080/#/c/4371/9/common/thrift/RuntimeProfile.thrift File common/thrift/RuntimeProfile.thrift: PS9, Line 94: summary stats counter > update Done -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
