Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ......................................................................
Patch Set 11: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/4371/10/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: Line 209: SummaryStatsCounter(TUnit::type unit, int32_t total_num_values, > I'm not sure what this comment means -- this is a constructor, so how can t Oops, that was meant for SetStats(). I put that here by mistake. I've removed this line here now. -- To view, visit http://gerrit.cloudera.org:8080/4371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf87bad90037dd0cea63b10c537382ec0f980cbf Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
