Tim Armstrong has posted comments on this change. Change subject: IMPALA-4383: Ensure plan fragment report thread is always started ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4864/1/be/src/runtime/plan-fragment-executor.h File be/src/runtime/plan-fragment-executor.h: Line 169: bool report_thread_active_; // true if we started the thread The protocol could do with some documentation - I had to piece it together by reading the code. E.g. - when the report thread starts, it sets 'report_thread_active_' to true and signals 'report_thread_started_cv_'. The report thread is shut down by setting 'report_thread_active_' to false and signalling 'stop_report_thread_cv_'. -- To view, visit http://gerrit.cloudera.org:8080/4864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d3cab4cc5245014758e6b70dec7a706a7fa929b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
