Juan Yu has posted comments on this change.
Change subject: IMPALA-4383: Ensure plan fragment report thread is always
started
......................................................................
Patch Set 1:
I agree with the fix. but just want to clarify the impact. I checked this piece
of code before. for each fragment we guarantee the status will be reported at
least once no matter report thread running or not, right?
void PlanFragmentExecutor::FragmentComplete() {
// Check the atomic flag. If it is set, then a fragment complete report has
already
// been sent.
bool send_report = completed_report_sent_.CompareAndSwap(0, 1);
...
if (send_report) SendReport(true);
}
--
To view, visit http://gerrit.cloudera.org:8080/4864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d3cab4cc5245014758e6b70dec7a706a7fa929b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Juan Yu <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No
