Dan Hecht has posted comments on this change. Change subject: IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4865/1/be/src/exec/plan-root-sink.h File be/src/exec/plan-root-sink.h: PS1, Line 84: after the commit message indicates it can be called concurrently as well... http://gerrit.cloudera.org:8080/#/c/4865/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 520: return Status(Substitute("Root fragment instance ($0) failed", PrintId(query_id_))); would the query ultimately fail with this status or with the status returned by the remote Prepare() failure? Is this a change of behavior and will it now be harder to know the real reason the query failed? Line 525: // fragment instance's executor will not complete until that point. is this comment still accurate or does it need refining for the cancel case? Line 1196: // CloseConsumer() here). See IMPALA-4275 for details. is this still accurate? if we moved this, would that eliminate the need to call CloseConsumer in PFE::Cancel()? http://gerrit.cloudera.org:8080/#/c/4865/1/be/src/runtime/plan-fragment-executor.cc File be/src/runtime/plan-fragment-executor.cc: Line 509: } nit:could be one line -- To view, visit http://gerrit.cloudera.org:8080/4865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4e25c1d658b3929182ba5e56b5c5e881dd394a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
