Dan Hecht has posted comments on this change. Change subject: IMPALA-4348 / IMPALA-4333: Improve coordinator fragment cancellation ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4865/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS2, Line 517: might have been cancelled what does it mean to "have been cancelled"? Since line 478 gets the lock, we wouldn't have cancelled it yet. Do you mean, "might have failed ..."? -- To view, visit http://gerrit.cloudera.org:8080/4865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4e25c1d658b3929182ba5e56b5c5e881dd394a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
