Tim Armstrong has posted comments on this change. Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4862/1/be/src/runtime/tuple.h File be/src/runtime/tuple.h: Line 95: Status DeepCopy(Tuple* dst, const TupleDescriptor& desc, MemPool* pool); > These deep copies are all over the place in the code. Do you want me to cha I'm fine if you go back to the old interface and use it for Kudu. We'll have to fix all the uses at some point but I don't think it should block this work. -- To view, visit http://gerrit.cloudera.org:8080/4862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
