Tim Armstrong has posted comments on this change. Change subject: IMPALA-3346: DeepCopy() Kudu rows into Impala tuples. ......................................................................
Patch Set 3: Code-Review+1 (3 comments) So much simpler. Just a few minor things. http://gerrit.cloudera.org:8080/#/c/4862/3/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 183: Tuple* kudu_tuple = reinterpret_cast<Tuple*>(const_cast<void*>(krow.cell(0))); Is the const_cast necessary? We shouldn't be modifying the memory. Ok to leave if there's some reason the types make it difficult to avoid. Line 198: *batch_done = true; Not your change but I think we should set *batch_done = false up the top of the function instead of relying on the caller to initialize. That's what we do almost everywhere else in the code. PS3, Line 215: 8 * (1 << 20) Let's make this a named constant just for clarity. -- To view, visit http://gerrit.cloudera.org:8080/4862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic911e4eff9fe98bf28d8a1bab5c9d7e9ab66d9cb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
