Lars Volker has posted comments on this change. Change subject: Add functional tests for compute stats with mt_dop > 0. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4879/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: PS1, Line 51: execute_query_using_client I think self.execute_query does the same. PS1, Line 52: location Why is it necessary to change the location here? I'm mostly curious because I did something similar in a different change and didn't specify a location, so the data files ended up in the unique_database's directory. Line 54: new_vector = deepcopy(vector) can you add a comment why this copy step is needed? -- To view, visit http://gerrit.cloudera.org:8080/4879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
