Alex Behm has posted comments on this change. Change subject: Add functional tests for compute stats with mt_dop > 0. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4879/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: PS1, Line 51: execute_query_using_client > I think self.execute_query does the same. That version doesn't switch the DB and extracting the DB manually from the vector is super painful. Added comment. PS1, Line 52: location > Why is it necessary to change the location here? I'm mostly curious because I want to just create "clone" of an existing table that has the same format and points to the same files. Create table like does not copy the location, so I need to specify it. Alternatives like CTAS don't work because it's not easy to specify the format in the CTAS, and we cannot insert into all formats. Line 54: new_vector = deepcopy(vector) > can you add a comment why this copy step is needed? For this test it's actually not needed because in every test we set the mt_dop exec option again. I was worried about modifying the vector in place and polluting the state of subsequent tests, but all tests use and set mt_dop anyway. -- To view, visit http://gerrit.cloudera.org:8080/4879 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd4e7e44f9f23f66e59ad1fb298e13da76ad817a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
