Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4896/3/be/src/service/impala-server.h File be/src/service/impala-server.h: PS3, Line 675: The lock must be acquired before 'query_exec_state_map_lock_' or : /// QueryExecState::lock_ if they will be held simulataneously. Instead of just having this above this lock, it would be better to spell out the lock ordering of the main locks in question at the top of this header file, based on the DAG you posted in the JIRA. I have a feeling there might be other places where we mess up the lock ordering too that we don't know of yet. -- To view, visit http://gerrit.cloudera.org:8080/4896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785fea0163a90d0633fb6ed77ec7c6882ab5c110 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
