Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4409: respect lock order in QueryExecState::CancelInternal() ......................................................................
Patch Set 4: (1 comment) if you could augment the comment to include the locks that aren't part of the hierarchy yet, that would be helpful. http://gerrit.cloudera.org:8080/#/c/4896/4/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: Line 215: /// holding this lock. what about this? -- To view, visit http://gerrit.cloudera.org:8080/4896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785fea0163a90d0633fb6ed77ec7c6882ab5c110 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
