Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: PS1, Line 300: RuntimeState::Close() > Agreed. TestEnv also creates RuntimeStates so we should call Close() there Fair point. I'm going to leave TestEnv for now - looking into that code it's a rat's nest, and we leak RuntimeStates everywhere as far as I can tell. Added it to fe-support - I added a utility to call Close() on scope exit, because there are so many paths out of that method... Line 304: ExecEnv::GetInstance()->thread_mgr()->UnregisterPool(resource_pool_); > Any reason for changing the order in which you are closing now? (Unregister No reason, don't think they're dependent. -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416e4d57240142bf685385299b749c3a6792c45 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
