Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: PS1, Line 300: RuntimeState::Close() > The ownership is actually really simple - TestEnv owns the RuntimeStates an Oh, I see - no the problem is that TestEnv a) calls them query states and b) allocates and returns a naked pointer before finally wrapping it in a shared_ptr at the end of the method. I can make that change. -- To view, visit http://gerrit.cloudera.org:8080/4893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie416e4d57240142bf685385299b749c3a6792c45 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
