Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer ......................................................................
Patch Set 2: > Do you have access to the file to repro'ed this in the wild? And > given that DCHECKs are compiled out of release builds, how did this > cause a problem in the wild? In the wild, some `insert into ... select from ...` queries have hit this check when converting CSV to Parquet, but I do not have access to those CSV files. A debug build was used while investigating an unrelated issue, that's how the DCHECK failure was noticed. -- To view, visit http://gerrit.cloudera.org:8080/4835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52e1b1354e9ea056b49331e75e53759952a81b76 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <z...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <z...@cloudera.com> Gerrit-HasComments: No