Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4371: Incorrect DCHECK-s in hdfs-parquet-table-writer ......................................................................
Patch Set 2: > Oh, oops, I wasn't noticing this was the writier. In that case, > why are these DCHECKs not valid? Why does our code create pages > with zero values (other than the last)? Or were we hitting the > non-zero compressed size dcheck (and if so, that also doesn't seem > to make sense). Originally I explained the reason in the commit message, but when I was asked to open a JIRA about it, I moved the explanation there. Please see https://issues.cloudera.org/browse/IMPALA-4371 -- To view, visit http://gerrit.cloudera.org:8080/4835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52e1b1354e9ea056b49331e75e53759952a81b76 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: No
