Alex Behm has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: Line 44: DECLARE_int32(kudu_client_timeout_ms); kudu_client_rpc_timeout_ms? or what exactly are we waiting for that can time out? http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: Line 114: DEFINE_int32(kudu_client_timeout_ms, 3 * 60 * 1000, "Timeout (milliseconds) set on Kudu " Not clear what is timing out. Is it an RPC? Connection attempt? Is there a special value for infinity? Is infinity allowed/recommended? http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: Line 60: Status CreateKuduClient(const std::vector<std::string>& master_addrs, remove std:: http://gerrit.cloudera.org:8080/#/c/4849/4/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: Line 246: // TODO: This is misleading when there are other errors, e.g. timeouts. yup, good point, it's difficult to properly report on many of the Kudu exceptions (connection problem vs. table does not exist, etc.) -- To view, visit http://gerrit.cloudera.org:8080/4849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad95e8e38aad4f76d21bac6879db6c02b3c3e045 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
