Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3771: Expose kudu client timeout and set default ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: Line 44: DECLARE_int32(kudu_client_timeout_ms); > kudu_client_rpc_timeout_ms? or what exactly are we waiting for that can tim see my comment where this is defined http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: Line 114: DEFINE_int32(kudu_client_timeout_ms, 3 * 60 * 1000, "Timeout (milliseconds) set on Kudu " > Not clear what is timing out. Is it an RPC? Connection attempt? Yes good point. This should apply for all operations, i.e. admin (create/delete tbls), metadata (get tablets), data (scanner and sink i.e. 'KuduSession'). Whether or not there are multiple RPCs is an implementation detail within the operation. I tried to make this more clear. I updated the comment and changed the name. I also simplified the usage where this is set after speaking with the Kudu folks. The BE code actually had some other flags for scanner/session timeouts that I removed and set this one instead. http://gerrit.cloudera.org:8080/#/c/4849/4/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: Line 60: Status CreateKuduClient(const std::vector<std::string>& master_addrs, > remove std:: Done -- To view, visit http://gerrit.cloudera.org:8080/4849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad95e8e38aad4f76d21bac6879db6c02b3c3e045 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
