Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ......................................................................
Patch Set 4: (10 comments) Looks pretty good. Just a bunch of small changes. I can give a +1 once those are done. http://gerrit.cloudera.org:8080/#/c/4867/4//COMMIT_MSG Commit Message: PS4, Line 21: , set of : gflags, to frontend, JniCatalog and JniFrontend to Catalog and Frontend. PS4, Line 23: entertain use? http://gerrit.cloudera.org:8080/#/c/4867/4/be/src/catalog/catalog.h File be/src/catalog/catalog.h: Line 104: Status GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray& cfg_bytes) const; nit: We generally use the return objects to be pointers and pass others by reference (see other methods above), something like Status GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) const; http://gerrit.cloudera.org:8080/#/c/4867/4/be/src/service/frontend.h File be/src/service/frontend.h: Line 176: Status GetFrontendConfigBytes(JNIEnv* jni_env, jbyteArray& cfg_bytes) const; nit: same as the comment in catalog.h http://gerrit.cloudera.org:8080/#/c/4867/4/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java File fe/src/main/java/org/apache/impala/common/RuntimeEnv.java: Line 39: private boolean computeLineage_; Remove. PS4, Line 46: computeLineage_ = BackendConfig.INSTANCE.getComputeLineage(); Remove. Update the callers to use BackendConfig. Line 60: public boolean computeLineage() { return computeLineage_; } Remove. http://gerrit.cloudera.org:8080/#/c/4867/4/fe/src/main/java/org/apache/impala/service/BackendConfig.java File fe/src/main/java/org/apache/impala/service/BackendConfig.java: Line 38: private boolean allowAuthToLocalRules_ = false; Remove. Line 45: private long incStatMaxSize_ = 0; Directly have a reference to TBackendConfig object here. PS4, Line 63: public long getIncStatMaxSize() { return incStatMaxSize_; } : public boolean isAuthToLocalEnabled() { return allowAuthToLocalRule return tBackendConfigObj.<method> directly. No need to have separate variables for each config. -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: Yonghyun Hwang <[email protected]> Gerrit-HasComments: Yes
