Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ......................................................................
Patch Set 5: (1 comment) agreed w/ bharath. Types.thrift is not good place for tbackendconfig. please propose other place. unless, let's live w/ it for now. http://gerrit.cloudera.org:8080/#/c/4867/2/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: PS2, Line 73: ABORT_IF_ERROR(GetCatalogConfigBytes(jni_env, &cfg_bytes)); : : jobject catalog = jni_env->NewObject(catalog_class_, catalog_ctor_, cfg_bytes); : EXIT_IF_EXC(jni_env); : ABORT_IF_ERROR(JniUtil::LocalToGlobalRef(jni_env, catalog, &catalog_)); : } : : Status Catalog::GetCatalogObject(const TCatalogObject& req, : TCatalogObject* resp) { : return JniUtil::CallJniMethod(catalog_, get_cata > Can you factor all this into a method, GetBackendConfig() or something simi Done -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: Yonghyun Hwang <[email protected]> Gerrit-HasComments: Yes
