Tim Armstrong has posted comments on this change. Change subject: IMPALA-1286: Extract common conjuncts from disjunctions. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4877/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1539: // TODO: Add option to disable expr rewrites for this test. This disjunction gets > Agree. I think we really want a query option to disable these kind of "opti How about we add a query test that tests || on a column with some NULLs in it so we're exercising the runtime code path? I don't really like the fact that the rewrite changes the type of the expression but it seems mostly harmless - how hard is it to retain the original type of the expression though? -- To view, visit http://gerrit.cloudera.org:8080/4877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cf9b950afaa3fd753d1b09ba5e540b5258940ad Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
