Lars Volker has posted comments on this change. Change subject: IMPALA-3202: refactor scratch file management into TmpFileMgr ......................................................................
Patch Set 3: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/4898/3/be/src/runtime/buffered-block-mgr.h File be/src/runtime/buffered-block-mgr.h: Line 508: /// is nit: line wrapping http://gerrit.cloudera.org:8080/#/c/4898/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: PS1, Line 296: x_ = ran > Good point, users have been confused by this before when the mixed terminol I agree that replacing Tmp with Scratch might not be worth it. Having those two works for me. Line 336: } else if (status.code() == TErrorCode::SCRATCH_LIMIT_EXCEEDED) { > I prefer it this way since it's more obvious that it's an "successful" retu Good point. http://gerrit.cloudera.org:8080/#/c/4898/1/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: PS1, Line 136: unique_i > I don't think it will ever be anything asides from the query id, but maybe Thanks. When I first saw query_id I assumed there might be some side effects that require query id semantics, so unique_id seems clearer to me. -- To view, visit http://gerrit.cloudera.org:8080/4898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c56c195f3f28d520034f8c384494e566635fc62 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
