Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: refactor scratch file management into TmpFileMgr ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4898/4/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: Line 292: " or see log for previous errors that prevented use of provided directories"); > does the log contain the errors, or do we need to log the error status at l The errors were logged via ReportIoError(). It makes more sense to accumulate the errors though and merge them together like we do below. Line 336: } else if (status.code() == TErrorCode::SCRATCH_LIMIT_EXCEEDED) { > seems like dead code now that the check is handled at the file group level, Yes, good we can simplify this. http://gerrit.cloudera.org:8080/#/c/4898/4/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: PS4, Line 72: allocation would exceed the allocation limit of its associated FileGrou > this check doesn't seem to be done by this function anymore. Done. Thought I removed this but memory must be faulty. -- To view, visit http://gerrit.cloudera.org:8080/4898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c56c195f3f28d520034f8c384494e566635fc62 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
