Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: Line 151: Status Catalog::GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) const { > It was created this way since Fe and Catalog can have their own set of conf Makes sense, but since impalad/catalogd are the same binary they can see all gflags, even if some of them only make sense for one or the other. In the FE we only have a single BackendConfig, which makes sense to me. Maybe we can make this a static function in ExecEnv()? -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: Yonghyun Hwang <[email protected]> Gerrit-HasComments: Yes
