Jim Apple has posted comments on this change. Change subject: Add -build_shared_libs for default build for speed. ......................................................................
Patch Set 1: > I'm ok with this as long as we have automated test coverage of this > script (in case the shared libs build breaks) and we stick with > using static linking for all automated testing (since that's the > configuration of Impala that is deployed). We do have automated coverage. I would love it if I'm sure many people deploy with -release and without -so, but it wouldn't surprise me if others ship with -so. -- To view, visit http://gerrit.cloudera.org:8080/4970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83db07e59ff339dcce7362bd296ebcfd60b71d6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
