Dan Hecht has posted comments on this change. Change subject: Add -build_shared_libs for default build for speed. ......................................................................
Patch Set 1: > I'm fine with this change, but I remember Dan had some reservations > when this change was initially proposed a long time ago. Dan? My concern was not with this change, but related. It was with a change that flipped to using shared libs everywhere, and my concern is that we should test something more similar to what we actually ship. i.e. tests and perf should still use static linking. For dev bootstrapping, I'm fine with this. -- To view, visit http://gerrit.cloudera.org:8080/4970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic83db07e59ff339dcce7362bd296ebcfd60b71d6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
