Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. ......................................................................
Patch Set 5: (9 comments) logging.cc Line 58: I can't use it by include impala-server.h, because this variable is const type, while impala-server.h only contains methods and member variables. It does not include this variable. http://gerrit.cloudera.org:8080/#/c/4971/1//COMMIT_MSG Commit Message: PS1, Line 2: davidxdh > nit: you might want to configure git to include your name here Done PS1, Line 10: dit e > fill up Done http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/init.cc File be/src/common/init.cc: PS1, Line 68: 0, > I don't think we should set a default here, because audit information might Done Line 69: "to retain. The most recent audit event log files are retained. If set to 0, " > Use spaces instead of tabs, wrap lines at 90 characters. You can use git-cl Done http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/init.cc File be/src/common/init.cc: Line 69: "to retain. The most recent audit event log files are retained. If set to 0, " > Please follow the indentation of the surrounding code Done http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/logging.cc File be/src/common/logging.cc: Line 58: // Prefix of audit event log filename. The version number is > Where in the code do we make sure that event log files are always written w This variable is referenced from AUDIT_EVENT_LOG_FILE_PREFIX at line 195 in be/src/service/impala-server.cc. I can't use it by include impala-server.h, because this variable is const while impala-server.h only contains methods and member variables. http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/logging.cc File be/src/common/logging.cc: Line 185: if (max_log_files <= 1) return; > This line looks wrong, please update comment. Done http://gerrit.cloudera.org:8080/#/c/4971/4/be/src/common/logging.cc File be/src/common/logging.cc: PS4, Line 61: AUDIT_EVENT_LOG_FILE_PREFIX I can't use it by include impala-server.h, because this variable is const type, while impala-server.h only contains methods and member variables. It does not include this variable. http://gerrit.cloudera.org:8080/#/c/4971/4/be/src/common/logging.h File be/src/common/logging.h: PS4, Line 85: /// Helper function that checks for the number of logfiles in the log directory and > please wrap this paragraph and the one below at 90 characters. Done -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <[email protected]> Gerrit-Reviewer: Donghui Xu <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
