Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
......................................................................


Patch Set 8:

(3 comments)

Thank you for reviewing my low level format errors so many time.
I will learn to use clang-format tool.:)

http://gerrit.cloudera.org:8080/#/c/4971/7//COMMIT_MSG
Commit Message:

Line 11: event log is enabled the growing number of log files will fill up the
> nit: comma
Done


http://gerrit.cloudera.org:8080/#/c/4971/7/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 17: 
> Please move this to the block of impala includes, starting in L34. Please k
Done


Line 57: mutex logging_mutex;
> Please remove this new line.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <[email protected]>
Gerrit-Reviewer: Donghui Xu <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to