Henry Robinson has posted comments on this change. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof ......................................................................
Patch Set 3: Code-Review+1 Just want to make sure I understand the bug that you've fixed in this latest patch: previously we called TryAllocateAligned() with an alignment larger than alignof(max_align_t) as a consequence of computing the requested alignment as RoundUpToPowerOfTwo(type_size) rather than alignof(type_size). -- To view, visit http://gerrit.cloudera.org:8080/5022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2dbabcb9af2874d8ed354738243dfca9c492b08 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
