Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof ......................................................................
IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof This was testing all memory alignments up to and including sizeof(max_align_t), but the standard says nothing about that. It does say things about alignof(max_align_t), including that malloc() returns memory at least that aligned. In both gcc and clang on our currently supported platforms, max_align_t has sizeof == 32 and alignof == 16, so this test expected an alignment that malloc was not guaranteed to provide. Change-Id: Ic2dbabcb9af2874d8ed354738243dfca9c492b08 Reviewed-on: http://gerrit.cloudera.org:8080/5022 Reviewed-by: Henry Robinson <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Jim Apple <[email protected]> --- M be/src/exprs/anyval-util.cc M be/src/exprs/anyval-util.h M be/src/runtime/mem-pool-test.cc M be/src/runtime/mem-pool.cc M be/src/runtime/mem-pool.h 5 files changed, 34 insertions(+), 13 deletions(-) Approvals: Jim Apple: Verified Henry Robinson: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2dbabcb9af2874d8ed354738243dfca9c492b08 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
