Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5026/4/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: Line 242: // List of keywords. Please keep them sorted alphabetically. Can you add a note about the default keyword? Alternatively, if you can make ident_or_default work, you can add a comment there. Line 920: | KW_ALTER KW_TABLE table_name:table KW_DROP opt_kw_column IDENT:col_name I think we may have to replace IDENT everywhere with ident_or_default, otherwise the uses here would need quoting for "default". Line 1503: // TODO: Consider introducing a DEFAULT keyword remove Line 2027: | KW_USE KW_DEFAULT Have you tried simplifying these changes with a production ident_or_default? Line 2189: KW_SET IDENT:key EQUAL literal:l Hmm IDENT really is everywhere. Maybe this is not such a good approach after all. Maybe we should give the %prec solution another try (I can help)? What do you think? Line 2243: | KW_DEFAULT DOT IDENT:tbl Unfortunately, you also need other cases like: IDENT DEFAULT DEFAULT DEFAULT -- To view, visit http://gerrit.cloudera.org:8080/5026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727b9ae1b7b2387db752b58081398dd3f3449c02 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
