Alex Behm has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options ......................................................................
Patch Set 6: Code-Review+2 (2 comments) +2 FE, +1 Catalog http://gerrit.cloudera.org:8080/#/c/5026/5/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: Line 129: public ColumnDef(String colName, TypeDef typeDef) { Seems like we'd often need a C'tor that also takes a comment string. You can internally create the appropriate map. http://gerrit.cloudera.org:8080/#/c/5026/5/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 250: c INT NOT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION, > For now I would say yes for the following reasons: AUTO and DEFAULT still seem uninformative. Let's revisit later like you suggested. -- To view, visit http://gerrit.cloudera.org:8080/5026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727b9ae1b7b2387db752b58081398dd3f3449c02 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
