Tim Armstrong has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4935/6/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 40: using namespace strings; This shouldn't be needed, we have 'using strings::Substitute' in names.h now. http://gerrit.cloudera.org:8080/#/c/4935/4/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 82: /// 2. session_state_map_lock_ > Similar-ish, but not as acute. We don't have the problem where we have this Sounds like we should file a JIRA for this. http://gerrit.cloudera.org:8080/#/c/4935/6/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: Line 79: void WaitForMetadataAvailable() { metadata_available_.Get(); } I think the new name is a bit misleading, because the metadata may not be available if an error is encountered in the meantime. There's an undocumented requirement to check the query status after calling this function. -- To view, visit http://gerrit.cloudera.org:8080/4935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I516357d2b5e9eb83e8209872cbe4c078c778a629 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
