Henry Robinson has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking ......................................................................
Patch Set 6: (1 comment) Abandoned this for now: Sailesh's comment lead me down a rat hole that I don't have time to address at the moment. We should pick this back up soon though, since the cascading locking can cause problems. http://gerrit.cloudera.org:8080/#/c/4935/6/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 40: using namespace strings; > This shouldn't be needed, we have 'using strings::Substitute' in names.h no Done -- To view, visit http://gerrit.cloudera.org:8080/4935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I516357d2b5e9eb83e8209872cbe4c078c778a629 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
