anujphadke has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/4633/8/be/src/runtime/plan-fragment-executor.cc File be/src/runtime/plan-fragment-executor.cc: PS8, Line 42: #include "runtime/runtime-state. > what do you need this for? This came from an older patch. Removed. http://gerrit.cloudera.org:8080/#/c/4633/8/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: PS8, Line 137: rage_wait_timer_ = > Does it work if you pass an empty string? I think "PlanFragmentThreads" is Done http://gerrit.cloudera.org:8080/#/c/4633/8/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: PS8, Line 323: total_thread_statistics > how about calling this total_thread_statistics_ or similar? Done -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
