anujphadke has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4633/6//COMMIT_MSG Commit Message: Line 9: This change removes the use of total_cpu_timer which incorrectly > Yes Done http://gerrit.cloudera.org:8080/#/c/4633/6/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: Line 138 > Why don't we create the thread counters here like before? This seems much c Done and I can access the private variable here too. http://gerrit.cloudera.org:8080/#/c/4633/6/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 242: /// 'failed_allocation_size' is zero, nothing about the allocation size is logged. > The convention is that the trailing underscore means that the member is pri Done. I start the timer in the runtime-state instead of in the plan-fragment-executor object. -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
