Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4833/4/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: Line 716: ctx.stats->IncrCounters(stats_name, 1, 1, !passed_filter); It seems inconsistent that we're not counting partitions processed before the filter arrived but we are counting rows. Would be good to clarify in filter-context.h what the counters mean more exactly. I feel like maybe we don't need 'total_possible' - 'considered' seems more informative. -- To view, visit http://gerrit.cloudera.org:8080/4833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27114869840e268d17e91d6e587ef811628e3837 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
