Dan Hecht has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5105/5/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: PS5, Line 463: CodegenDisabledByHint( is this correct? we might still codegen if there's an IR udf, right? See also comments in runtime.h. http://gerrit.cloudera.org:8080/#/c/5105/5/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: PS5, Line 171: codegen is disabled due to hints is this true? doesn't this just indicate whether the hint would like to disable codegen (not whether codegen actually is disabled)? PS5, Line 175: CodegenDisabledByHint if my above question is right, then this should be called CodegenDisableHint(), since "DisabledByHint" sounds like it was disabled for sure. Alternatively, I'd expect a function that is called CodegenDisabledByHint() to be defined as: return query_ctx().disable_codegen_hint && !HasScalarFnToCodegen(); (that would also fix the issue noted in AddCodegenDisableMessage()) -- To view, visit http://gerrit.cloudera.org:8080/5105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b6a9ed723c64ba21b861608583cc9b6607d3397 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
