Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5105/6/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: PS6, Line 169: HasScalarFnToCodegen > Maybe ScalarFnRequiresCodegen() or similar? i.e. to make it clear that not Done Line 171: /// Returns true if there is hint to disable codegen. This can be true for single node > "a" Done Line 180: /// of the hint and all expressions in the fragment can be interpreted. > given that this depends on the scalar_fns_to_codegen_ state which isn't que Done. The exact point in which scalar_fn_to_codegen_ is usable may change in an upcoming change. PS6, Line 191: followings > following. Done Line 194: /// which cannot be interpreted. > I think this would be clearer without the double negative. eg.: Done -- To view, visit http://gerrit.cloudera.org:8080/5105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b6a9ed723c64ba21b861608583cc9b6607d3397 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
