Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/5047/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: Line 244: // Today there is no comprehensive way of enforcing a Sentry authorization policy > Needs brief comment explaining why this privilege level is required, point Done http://gerrit.cloudera.org:8080/#/c/5047/2/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java: Line 249: for (String columnName: columnNames_) { > brief comment and pointer to JIRA Done Line 281: throw new AnalysisException(String.format("Error setting privileges for " + > brief comment and pointer to JIRA Done Line 283: "to issue a GRANT/REVOKE statement.", tableName_.toString())); > Kudu tables only support the ALL privilege level. Done http://gerrit.cloudera.org:8080/#/c/5047/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: Line 907: // tables. > also add a positive test case Done Line 912: // IMPALA-4000: ALL privileges on SERVER are not required to create managed tables. > isn't this already covered somewhere? I couldn't find a test like this for Kudu. (it would make sense that it would be in this file, right?) http://gerrit.cloudera.org:8080/#/c/5047/2/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: Line 296: ---- QUERY > looks more like an analyzer test Done -- To view, visit http://gerrit.cloudera.org:8080/5047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I183f08ad8ce80deee011a6b90ad67b9cefc0452c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
