Alex Behm has posted comments on this change. Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables ......................................................................
Patch Set 5: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/5047/5/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: Line 247: // See IMPALA-4000 for details. move into previous line Line 249: if (authzServer != null) { instead of checking for null, check that authorization is enabled, and inside the if add a preconditions check that the server name is not null http://gerrit.cloudera.org:8080/#/c/5047/5/fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java File fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java: Line 289: // See IMPALA-4000 for details. move into previous line -- To view, visit http://gerrit.cloudera.org:8080/5047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I183f08ad8ce80deee011a6b90ad67b9cefc0452c Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
