Henry Robinson has posted comments on this change. Change subject: Avoid std::function when possible. ......................................................................
Patch Set 1: I checked EMC++ and the ppt you linked to. Am I right to summarise that your main objection is that std::function() heap allocates? Is that a different issue than classes that use STL containers also might heap allocate on construction? I see that there are other reasons to prefer auto in certain situations (e.g. performance), but those mostly seemed like case-specific concerns rather than something we should make general. -- To view, visit http://gerrit.cloudera.org:8080/5230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9dc034c2e094ea7f87f78d8d9101a71d8d2e295 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-HasComments: No
