Henry Robinson has posted comments on this change. Change subject: Avoid std::function when possible. ......................................................................
Patch Set 1: > It's the added hidden run-time complexity generally Can you be more specific? Abstractions naturally hide complexity; what are the gotchas that you think mean we shouldn't use std::function? -- To view, visit http://gerrit.cloudera.org:8080/5230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9dc034c2e094ea7f87f78d8d9101a71d8d2e295 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: No
