Tim Armstrong has posted comments on this change. Change subject: IMPALA-4525: follow-on: cleanup error handling ......................................................................
Patch Set 4: Code-Review+2 (3 comments) Carry +2 http://gerrit.cloudera.org:8080/#/c/5212/3/be/src/service/fe-support.cc File be/src/service/fe-support.cc: PS3, Line 82: Status status; > Why not just Status status; ? Done Line 120: There was a bug here - turns out we need to call Close() after Prepare() even if Prepare() fails. PS3, Line 138: > for (ExprContext* expr_ctx : expr_ctxs) { Done -- To view, visit http://gerrit.cloudera.org:8080/5212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2e532381c3e6c7b2e3ef37c2d91fbebb2db2d0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
