Jim Apple has posted comments on this change. Change subject: Add Apache license header to files in doc directory ......................................................................
Patch Set 2: (1 comment) > (1 comment) > > Looks good. (Does the +2 initiate any further transfer of files or > do you as the code review creator still have to do all the followup > git commands to get the changes over to master?) +2 does nothing but +2. "Submit" puts it in gerrit's master branch. bin/push_to_asf.py copies patches from gerrit's master branch to apache's master branch. http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG Commit Message: PS2, Line 7: Add Apache license header to files in doc directory > Is that another sed script? If so, let's save that somewhere so we can run No, I used "replace". As I mentioned on another patch, discussion of Cloudera-specific docs files is off-topic for this forum. Patches here are to Apache Impala (incubating). -- To view, visit http://gerrit.cloudera.org:8080/5232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Anonymous Coward #250 Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
