John Russell has posted comments on this change. Change subject: Add Apache license header to files in doc directory ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG Commit Message: PS2, Line 7: Add Apache license header to files in doc directory > No, I used "replace". To sanity-check the logic, what was the exact 'replace' command? I.e. was it to replace line 1: <?xml version="1.0" encoding="UTF-8"?> with line 1 + version notice? Is/was there an option to say "only replace the first instance"? If there's an unusual file with a different <?xml?> header line, or a second instance inside a comment, I would doublecheck that with grep -l or grep -c for an extra level of confidence. That's why it helps me to know the precise search/replace procedure. -- To view, visit http://gerrit.cloudera.org:8080/5232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ad06435f84a65ba126759e42a18fdaf52cd7036 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Anonymous Coward #250 Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
