Michael Brown has posted comments on this change. Change subject: Add pytest option and skip markers for tests that only run locally. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5446/1//COMMIT_MSG Commit Message: PS1, Line 7: Add pytest option and skip markers for tests that only run locally. Please add Jira ID. http://gerrit.cloudera.org:8080/#/c/5446/1/tests/common/skip.py File tests/common/skip.py: PS1, Line 120: class SkipIfRemoteTesting: : """Skip marker for those tests that may not work on remote clusters.""" : local_cluster_only = pytest.mark.skipif(pytest.config.option.skip_local_only_tests, : reason="--skip_local_only_tests specified") I'm fine with the class name. I'm less enthused on the command line name. We already have one notion of "local", which is the local filesystem as opposed to HDFS et al. Now we are introducing another notion of "local". Is there a philosophical argument I'm missing against something like "--remote-cluster-tests" ? That is more precise and clear as to the nature of the testing. -- To view, visit http://gerrit.cloudera.org:8080/5446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
