Tim Armstrong has posted comments on this change. Change subject: Add pytest option and skip markers for tests that only run locally. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5446/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: PS1, Line 95: @SkipIfRemoteTesting.local_cluster_only > From just looking at this it is not clear to me whether this is skipped or I think also it's confusing when we have the distinction between a local HDFS cluster and local filesystem. Maybe this could be minicluster_only? Line 99: self.run_test_case('QueryTest/mt-dop-parquet-nested', vector) Why isn't this test expected to succeed on a cluster? It seems like it should work unless there's a product bug. -- To view, visit http://gerrit.cloudera.org:8080/5446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4d6e46dc1e64ad20c727ccb19af7a9f3daf917f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
