Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/1/be/src/exec/kudu-scanner.h File be/src/exec/kudu-scanner.h: PS1, Line 70: current scanner > Should this be "current Kudu scan batch" ? yes thanks, also this should indicate that this returns OK w/ one of these conditions. I'll update that too. -- To view, visit http://gerrit.cloudera.org:8080/5493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddd51111a1b2647995d68e6d37d0500b3a322de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
