Tim Armstrong has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: PS2, Line 200: scan_node_->ReachedLimit() > Yeah this is a good point, I'll file a separate JIRA for us to address how Agree we should fix it. I think we won't run into any (serious) problems in practice, since there's a memory barrier when we acquire the queue locks to add each batch. The once-per-row check here may not behave as expected since it could be cached. In the HDFS scanners I believe it's only checked once per batch anyway. The scan node needs to truncate the batches correctly regardless. I don't think we need to check this every row for Kudu, so we should consider changing it. -- To view, visit http://gerrit.cloudera.org:8080/5493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddd51111a1b2647995d68e6d37d0500b3a322de Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
